NVTabular icon indicating copy to clipboard operation
NVTabular copied to clipboard

[BUG] Criteo TensorFlow examples does not use numerical features

Open bschifferer opened this issue 3 years ago • 3 comments

Describe the bug Numeric Inputs in TensorFlow example for scaling criteo are not used in the next layers

bschifferer avatar Dec 13 '21 10:12 bschifferer

@bschifferer is this still a valid issue? Can you provide more details?

EvenOldridge avatar Jun 10 '22 00:06 EvenOldridge

@EvenOldridge @viswa-nvidia what Benedikt refers here that in the scaling-criteo 03-Training-with-TF.ipynb notebook, we define numerical layers for numerical features, but they are never fed in the model architecture, therefore it is not used. The issue is still valid, yes.

rnyak avatar Jun 15 '22 12:06 rnyak

@rvk007 created a PR to update the TensorFlow model with Merlin Models. I need to review it, but I think we will fix the issue soon

bschifferer avatar Jun 20 '22 16:06 bschifferer

We updated the example to use merlin models (in Merlin/Merlin repo)

bschifferer avatar Aug 23 '22 13:08 bschifferer