[RMP] Rework the NVT example notebooks to use other Merlin libraries?

Open karlhigley opened this issue 3 years ago • 6 comments

NVTabular

Note: The scope of this is TBD and to be discussed in upcoming meetings

Currently, nvtabular holds all integration tests. These tests are supposed to evaluate integration of NVTabular with the merlin components and target frameworks (i.e. Tensorflow, Torch). Updates need to be made to meet this requirement.

[x] Integrate Merlin Models into the example notebooks
[x] Integrate Merlin Systems into the example notebooks
[ ] Migrate the NVT example notebook unit tests to use Testbook
[ ] Set up integration tests for NVT example notebooks
[ ] NVIDIA-Merlin/NVTabular#1416
[ ] Decide what metrics to capture to ASV for NVTabular notebooks
[ ] NVIDIA-Merlin/NVTabular#1417

May 02 '22 17:05 karlhigley

Excerpted from NVIDIA-Merlin/NVTabular#205, which is specifically focused on improving testing

May 02 '22 17:05 karlhigley

we should also decide what to migrate to other repos and what to remove all together.

May 02 '22 18:05 jperez999

Another related issue (potentially as follow-up work to this) is that we'd like to remove the dataloaders and framework utils from NVTabular since they've moved to Merlin Models, but the current example notebooks rely heavily on both the NVT dataloaders and framework utils. (So does the bench directory, for that matter.)

May 02 '22 18:05 karlhigley

thanks for splitting. I think we need one first ToDo - "Decide where current NVTabular examples will stay" & "Decide which NVTabular examples should be migrated to Merlin Models & Merlin Systems"