PowerSystems.jl icon indicating copy to clipboard operation
PowerSystems.jl copied to clipboard

PSY Remaining TODOs for Second Cost Refactor

Open GabrielKS opened this issue 1 year ago • 2 comments

This is a list of TODOs that remain unfinished from https://github.com/NREL-Sienna/PowerSystems.jl/pull/1071, they should all be addressed before PSY 4 is released.

  • [ ] Make other fields of MarketBidCost time series, see https://github.com/NREL-Sienna/PowerSystems.jl/pull/1071#discussion_r1579880930
  • [ ] Verify correctness of power_system_table_data.jl, possibly write new tests (cmd-F Strange math, see also https://github.com/NREL-Sienna/PowerSystems.jl/pull/1071#discussion_r1548537062)
  • [ ] Nail down naming of everything to both conform to power systems domain conventions and not be misleading about what things are
  • [ ] Nail down what is part of the public interface (e.g., just the cost aliases or ValueCurves?)
  • [ ] Do this to support 3 -> 4 system conversions: https://github.com/NREL-Sienna/PowerSystems.jl/blob/234936ef5e06c47388d560511ec6c817f4f30864/src/data_format_conversions.jl#L107
  • [ ] Minor TODO(?): https://github.com/NREL-Sienna/PowerSystems.jl/blob/234936ef5e06c47388d560511ec6c817f4f30864/test/test_constructors.jl#L24
  • [ ] Minor TODO: https://github.com/NREL-Sienna/PowerSystems.jl/blob/234936ef5e06c47388d560511ec6c817f4f30864/src/PowerSystems.jl#L553
  • [ ] Fill in TODOs in https://github.com/NREL-Sienna/PowerSystems.jl/blob/234936ef5e06c47388d560511ec6c817f4f30864/docs/src/modeler_guide/cost_functions.md
  • [ ] Address https://github.com/NREL-Sienna/PowerSystems.jl/issues/1048
  • [ ] Already covered by other items, but https://github.com/NREL-Sienna/PowerSystems.jl/blob/234936ef5e06c47388d560511ec6c817f4f30864/src/models/cost_functions/cost_aliases.jl#L84

GabrielKS avatar Apr 22 '24 21:04 GabrielKS

On the get_points, it isn't too much of a problem since the geographic info uses GeoJSON blobs.

jd-lara avatar Apr 30 '24 17:04 jd-lara

#1081 Is also part of this list

jd-lara avatar May 01 '24 16:05 jd-lara

wrt "Nail down naming of everything," would someone with a power systems background like to review my naming?

GabrielKS avatar Jun 11 '24 20:06 GabrielKS

@GabrielKS can you update the list and close if this is pretty much ready please?

jd-lara avatar Jun 25 '24 14:06 jd-lara