NCEPLIBS-g2c icon indicating copy to clipboard operation
NCEPLIBS-g2c copied to clipboard

pdstemplate 35 says it needs extension, but no code handles it in extpdstemplate() so no extension is allocated

Open edwardhartnett opened this issue 3 years ago • 10 comments
trafficstars

pdstemplate 35 says it needs extension, but no code handles it in extpdstemplate() so no extension is allocated.

From pdstemplates.c:

/**             VALIDATION --- PDT 4.35
                PDT 4.35  (10/07/2015)
                4.35: Individual ensemble reforecast, control and perturbed,
                at a horizontal level or in a  horizontal layer
                in a continuous or non-continuous time interval. */
    {35,6,1, {1,1,1,1,1,1} }

Yet in the function extpdstemplate() there is no handler for number == 35.

There is a test for this in tst_pdstemplates.c.

@BoiVuong-NOAA do you know what is the deal with pdstemplate 35?

edwardhartnett avatar Dec 08 '21 13:12 edwardhartnett

No, I do not. This was validation of template 4.35 during WMO group developed this template. We do not have any data to test with it.

BoiVuong-NOAA avatar Dec 08 '21 13:12 BoiVuong-NOAA

I will bump this to the next release...

edwardhartnett avatar Dec 08 '21 13:12 edwardhartnett

Do you have the time for the next release ?

BoiVuong-NOAA avatar Dec 08 '21 13:12 BoiVuong-NOAA

Do you know of some reason why a release is needed?

edwardhartnett avatar Dec 08 '21 13:12 edwardhartnett

Users in UPP are waiting for this release to work on their development. I have given them the code for testing since in 9/2021.

BoiVuong-NOAA avatar Dec 08 '21 13:12 BoiVuong-NOAA

Who is involved in this code in UPP?

Why are they waiting on the next release? I am not aware that it contains any new feature or bugfix that would be important to them...

edwardhartnett avatar Dec 08 '21 13:12 edwardhartnett

These are new fields and requested by Tracy Hertneky and Lin L Zhu and Wen Meng. If you can not release now, then they have to wait for it. Note: It is not a bugfix.

BoiVuong-NOAA avatar Dec 08 '21 14:12 BoiVuong-NOAA

We can release. Are you going to add the fields to this repo as well?

edwardhartnett avatar Dec 08 '21 14:12 edwardhartnett

Yes, I all add these fields in the test code. Note: These fields are not used in G2C library.

BoiVuong-NOAA avatar Dec 08 '21 15:12 BoiVuong-NOAA

I also note that there is no extension info provided for template 35 in the fortran library either.

edwardhartnett avatar Oct 18 '22 19:10 edwardhartnett