ldns icon indicating copy to clipboard operation
ldns copied to clipboard

Address several issues with the ultimate goal being to fix Coverity cited problems

Open ngie-eign opened this issue 1 year ago • 4 comments

  • Update .gitignore to ignore more build generated files.
  • Fix typos (the the -> the).
  • Fix a memory leak.
  • Fix a bad type/potential unsigned integer overflow issue.

ngie-eign avatar Jun 06 '24 05:06 ngie-eign

This set of changes looks nice to me. Unbound has similar issues, because it has the same code in certain places, it needs the memory leak fix and some of the spelling fixes. I have created commits to the unbound code base to fix them, in https://github.com/NLnetLabs/unbound/commit/3cad5818a1b894415c3cd85987320e79717cf5c0 and https://github.com/NLnetLabs/unbound/commit/1974732d19229a6d885c2926db96e447590e5b86 .

wcawijngaards avatar Jun 06 '24 07:06 wcawijngaards

This set of changes looks nice to me. Unbound has similar issues, because it has the same code in certain places, it needs the memory leak fix and some of the spelling fixes. I have created commits to the unbound code base to fix them, in NLnetLabs/unbound@3cad581 and NLnetLabs/unbound@1974732 .

Much appreciated! I looked at those PRs -- do I need to submit entries to the ChangeLog as well for the proposed changes, or is that something maintainers can handle?

ngie-eign avatar Jun 06 '24 16:06 ngie-eign

Much appreciated! I looked at those PRs -- do I need to submit entries to the ChangeLog as well for the proposed changes, or is that something maintainers can handle?

I should be able to handle that :grin: . How would you prefer to be credited? As ngie-eign or with your full name. Cheers!

wtoorop avatar Jun 07 '24 06:06 wtoorop

]

Much appreciated! I looked at those PRs -- do I need to submit entries to the ChangeLog as well for the proposed changes, or is that something maintainers can handle?

I should be able to handle that 😁 . How would you prefer to be credited? As ngie-eign or with your full name. Cheers!

Thanks! Could you please use my legal name (Enji Cooper) :)?

ngie-eign avatar Jun 07 '24 16:06 ngie-eign