software-engineering-quality-framework icon indicating copy to clipboard operation
software-engineering-quality-framework copied to clipboard

Failing link check

Open regularfry opened this issue 2 years ago • 6 comments

Just a sanity check to see what the behaviour of the link checker is around redirects.

regularfry avatar Oct 16 '23 10:10 regularfry

Setting "ready for review" to get the markdown link checker action to run. Don't worry about reviewing.

regularfry avatar Oct 16 '23 10:10 regularfry

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 16 '23 10:10 sonarqubecloud[bot]

Ok, so this has passed. Looking through the dependency stack I couldn't see anything obviously wrong about the way timeouts are handled, but replacing redirected links with their eventual destination means fewer network requests, so fewer opportunities to go wrong. The increased timeout also means that if we are getting rate-limited at the other end, we're less likely to see a failure as a result.

regularfry avatar Oct 16 '23 13:10 regularfry

Ah is there a timeout setting on this action - it does throw a few false negatives, which are a nuisance

andyblundell avatar Nov 09 '23 14:11 andyblundell

Ah is there a timeout setting on this action - it does throw a few false negatives, which are a nuisance

Yeah, I've changed it to 30 seconds. It defaults to 10. I'm unclear what would fail at 10 seconds but pass at 30. It just doesn't seem like a very natural breakpoint unless we're getting rate limited somewhere.

regularfry avatar Nov 10 '23 10:11 regularfry

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 23 '24 14:01 sonarqubecloud[bot]