Potential Node.js Version Compatibility Issue with Sinon in GitHub Actions

[robyngit]

We're encountering an issue with our tests running in GitHub Actions that I suspect may be related to a Node.js version compatibility problem with sinon, a newly introduced dev dependency. On a mac with node v18.2.0, tests on feature branches with sinon are passing without any issues. However, in GitHub Actions, we're seeing repeated test failures. Debug logs gave no particular hints as to why.

Sinon 10 and above supports only Node.js LTS versions (20.x as of now), but our GitHub Actions are using Node 16.x, so we suspect a compatibility issue is causing the actions to fail.

We should verify that the node version is the problem, and then either update our GH action Node.js version or use an older sinon version to ensure compatibility.

[robyngit]

Further investigation shows that the node version may not be the problem here, as there are some feature branches with sinon where the tests pass on GitHub actions. Locally, I used nvm to install node v16.20.2 and also was able to get tests to pass in the feature-1795-layer-search branch where the failing GH tests are occurring.

[robyngit]

Note we now get a warning from GitHub actions:

test (16.x)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[robyngit]

We switch to node 18 with release 2.29.1