sbpy icon indicating copy to clipboard operation
sbpy copied to clipboard

Allow measurement errors in `photometry.DiskIntegratedPhaseFunc.from_obs` method

Open jianyangli opened this issue 3 years ago • 0 comments

This is a request for

  • [ ] a new feature
  • [x] an enhancement to existing sbpy functionality
  • [ ] somethings else: [explain here]

The requested changes will be implemented by

  • [x] me
  • [x] the sbpy developers

High-level concept sbpy.photometry.DiskIntegratedPhaseFunc provides class method from_obs to fit observational data and retrieve a phase function model. The current implementation doesn't use measurement errors in the fit. This enhancement should allow the use of measurement errors if present in the input.

Explain the relevance to sbpy Enhancement to existing sbpy class method.

Proposal details Check the existence of measurement errors in the input, and pass to fitter if present.

Example (pseudo-)code

jianyangli avatar Jun 30 '22 03:06 jianyangli