sui icon indicating copy to clipboard operation
sui copied to clipboard

[Swarm] Set default committee size to 4

Open lxfind opened this issue 1 year ago • 1 comments

Description

With committee size of 1, the network cannot remain live. Set it to 4 to avoid mistakes in tests.

Test plan

CI


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] Indexer:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:
  • [ ] REST API:

lxfind avatar Sep 30 '24 23:09 lxfind

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (18da83a) to head (bf135b3).

Files with missing lines Patch % Lines
Dynamic-Programming/spiralMatrix.js 98.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   84.65%   84.69%   +0.03%     
==========================================
  Files         378      379       +1     
  Lines       19744    19794      +50     
  Branches     2951     2965      +14     
==========================================
+ Hits        16715    16764      +49     
- Misses       3029     3030       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 06 '24 17:10 codecov-commenter

I would consider this more of a solution to a programming problem than something which is algorithmically very involved so I'm afraid I'm not sure this is in scope. @raklaptudirm what do you think?

appgurueu avatar Oct 07 '24 00:10 appgurueu

@appgurueu This solution is an approach to solving similar spiral matrix-related problems. Does that make sense? If not, could you please suggest any changes?

rajprogrammerbd avatar Oct 07 '24 17:10 rajprogrammerbd

This solution is an approach to solving similar spiral matrix-related problems.

I'm aware of what this code implements. I'm just not convinced it fits here: I think it's more of a "programming" problem than an "algorithm" problem, if that makes sense.

appgurueu avatar Oct 07 '24 19:10 appgurueu