sui
sui copied to clipboard
[Rosetta] - serialize total_coin_value to string instead of number to prevent precision lost
Description
As titled
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] REST API:
Codecov Report
Attention: Patch coverage is 87.93970% with 24 lines in your changes missing coverage. Please review.
Project coverage is 84.69%. Comparing base (
9010481) to head (49de7a5). Report is 2 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| Geometry/FindIntersections.js | 87.93% | 24 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
+ Coverage 84.65% 84.69% +0.03%
==========================================
Files 378 379 +1
Lines 19744 19943 +199
Branches 2951 2981 +30
==========================================
+ Hits 16715 16890 +175
- Misses 3029 3053 +24
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have made changes. Please review and let me know if anything is missing. Thanks.
:confused: