sui icon indicating copy to clipboard operation
sui copied to clipboard

(feat)Indexer: Add `raw_transaction_sigs` column and switch `raw_transaction` to BCS serialize TransactionData

Open stefan-mysten opened this issue 1 year ago • 2 comments
trafficstars

Description

Adds one column for raw_transaction_sigs representing the BCS bytes of Vec<GenericSignature>. Switches from BCS serializing SenderSignedData to TransactionData for raw_transaction.

Test plan

Existing tests.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] Indexer:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:
  • [ ] REST API:

stefan-mysten avatar Sep 21 '24 04:09 stefan-mysten

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.79%. Comparing base (ff314a2) to head (8d2c4b4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
+ Coverage   84.76%   84.79%   +0.02%     
==========================================
  Files         378      379       +1     
  Lines       19742    19773      +31     
  Branches     2955     2962       +7     
==========================================
+ Hits        16735    16766      +31     
  Misses       3007     3007              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 09 '24 15:10 codecov-commenter

@raklaptudirm @appgurueu please review and merge

pomkarnath98 avatar Oct 13 '24 17:10 pomkarnath98