Reference implementation of the Soft Bundle API proposal

[shio-coder]

Description

Please refer to this SIP draft: https://github.com/sui-foundation/sips/pull/19

Test Plan

The feature is not exactly user-facing and do not break anything.

Type of Change (Check all that apply)

• [x] protocol change
• [ ] user-visible impact
• [ ] breaking change for a client SDKs
• [ ] breaking change for FNs (FN binary must upgrade)
• [ ] breaking change for validators or node operators (must upgrade binaries)
• [ ] breaking change for on-chain data layout
• [ ] necessitate either a data wipe or data migration

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sui-core	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 9:11am

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
multisig-toolkit	⬜️ Ignored (Inspect)	Visit Preview		Apr 18, 2024 9:11am
sui-kiosk	⬜️ Ignored (Inspect)	Visit Preview		Apr 18, 2024 9:11am
sui-typescript-docs	⬜️ Ignored (Inspect)	Visit Preview		Apr 18, 2024 9:11am

[shio-coder]

Most changes under narhwhal/ look good, except that we probably want to ensure batch size limit with soft bundles as well.

Since we will be rolling out Mysticeti soon, I think it will be useful to consider making the same change for consensus/. We can merge the consensus/ and narwhal changes first, which can be less complex and sensitive than sui-core changes.

Hi Mingwei,

Thanks for the comments!

It indeed makes more sense to break down the PR.
I will start a separated PR for consensus changes. Once it gets merged, we work on the remaining parts.

[shio-coder]

Hey folks,

I have created a new PR that focuses on consensus changes: https://github.com/MystenLabs/sui/pull/17508

For the comments in the current PR, I have tried my best to make changes and incorporated into the new one.

Please take another look.

Thanks

[github-actions[bot]]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[stefan-mysten]

@shio-coder. I see that the consensus related PR has been approved and merged. I assume this is still an important addition to Sui, so what's needed next to move this PR forward?

cc @lxfind @mwtian @mystenmark

[mwtian]

The execution part has been merged as well. @shio-coder I think we can close this PR now?

[shio-coder]

@shio-coder. I see that the consensus related PR has been approved and merged. I assume this is still an important addition to Sui, so what's needed next to move this PR forward?

cc @lxfind @mwtian @mystenmark

There are a few things on my mind as the next steps:

• We are working with partners to test the feature on testnet right now. If this goes well, the next step is to move to the mainnet so that they can launch their product features.
• Provide better observability into the feature, that is metrics and maybe traces. So that a validator operator can understand what is happening.

Will close the PR now, since all related ones have already been merged.