sui icon indicating copy to clipboard operation
sui copied to clipboard

Compute metadata flag to optimize gas.

Open Rajwanshi1 opened this issue 1 year ago • 1 comments

Description

Added compute_metadata flag to compute metadata only when required by the caller. Return val for metadata has been changed to Option<T>.

Test Plan

This proposed change does'nt affect signature of any public func. Hence, existing tests should suffice.


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • [ ] protocol change
  • [ ] user-visible impact
  • [ ] breaking change for a client SDKs
  • [ ] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

Rajwanshi1 avatar Dec 08 '23 07:12 Rajwanshi1

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 2:37pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 2:37pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 2:37pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:37pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:37pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 2:37pm

vercel[bot] avatar Dec 08 '23 07:12 vercel[bot]

@Rajwanshi is attempting to deploy a commit to the Sui Foundation Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 12 '24 06:01 vercel[bot]

@Rajwanshi thanks a lot for the changes! @patrickkuo is going to do a final follow up and then I understand we will take it a push it in, right?

dariorussi avatar Jan 19 '24 14:01 dariorussi

Hey guys, let me know if there is any update on this PR

Rajwanshi1 avatar Feb 05 '24 09:02 Rajwanshi1