sui icon indicating copy to clipboard operation
sui copied to clipboard

deepbook lot_size error in func match_bid_with_quote_quantity

Open honeywest opened this issue 2 years ago • 1 comments
trafficstars

lot_size has no effect in func match_bid_with_quote_quantity optimize: add code filled_base_quantity = filled_base_quantity - (filled_base_quantity % lot_size) and add another condition to end the loop https://github.com/MystenLabs/sui/blob/021a40dc2536fa7698b9faecbad86d3278869d43/crates/sui-framework/packages/deepbook/sources/clob.move#L377

honeywest avatar Apr 21 '23 14:04 honeywest

@sblackshear see

honeywest avatar Apr 21 '23 14:04 honeywest

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 21 '23 01:06 github-actions[bot]

@0xaslan @leecchh I assume this is not relevant anymore, but wanted to flag it anyway! If it's all good, we can close the issue. Thanks!

stefan-mysten avatar Jul 02 '24 15:07 stefan-mysten

Thanks @stefan-mysten , yes this is not relevant anymore. Closing the issue. All new changes will be shipped with DeepBook v3.

0xaslan avatar Jul 02 '24 17:07 0xaslan