sui icon indicating copy to clipboard operation
sui copied to clipboard

Fix: Return None instead of passing Error

Open icodezjb opened this issue 2 years ago • 1 comments

Description

Regardless of whether the client has set show_balance_changes and show_object_changes, For the client, we need to return the effect, and the client checks effect.status

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • [ ] user-visible impact
  • [ ] breaking change for a client SDKs
  • [ ] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

icodezjb avatar Apr 18 '23 06:04 icodezjb

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Apr 18, 2023 7:50am
explorer-storybook ⬜️ Ignored (Inspect) Apr 18, 2023 7:50am
sui-wallet-kit ⬜️ Ignored (Inspect) Apr 18, 2023 7:50am
wallet-adapter ⬜️ Ignored (Inspect) Apr 18, 2023 7:50am

vercel[bot] avatar Apr 18 '23 06:04 vercel[bot]

https://github.com/MystenLabs/sui/pull/11466/files

icodezjb avatar May 03 '23 12:05 icodezjb