Scott Schafer
Scott Schafer
It would be nice to see perf results on these changes. Going from 3 -> 4 `rustc` invocations could be a larger hit than using `rustup` wrapper.
> I'm wondering, though, does rust-analyzer not show a quick-fix for fixable suggestions? Perhaps that would be a better route to make it easier for people to apply suggestions, or...
I've updated this with feedback from #10976. Changes: - The note is added to the summary line as [suggested here](https://github.com/rust-lang/cargo/issues/10976#issuecomment-1215921821) - The command to run now includes the exact command...
> I am uncertain whether we need to make sure the suggested command is always runnable. A bad suggestion could be worse than no suggestion. I agree that a bad...
If I remember correctly https://github.com/rust-lang/rustup/issues/2626 is related to this and was fixed in rustup version `1.25.0` but had to be reverted in `1.25.1`. https://github.com/rust-lang/rustup/issues/3035 should be the related tracking issue.
This seems interesting, I'd love to work on it if we can figure out what the message should be. I lean towards an explicit callout to `cargo --fix` but I...
How I have it currently working doesn't work for clippy as its a subcommand
It was discussed in a recent [cargo team](https://www.rust-lang.org/governance/teams/dev-tools#cargo) meeting to move forward with showing a message that `cargo fix` can fix some **warnings** but only on **nightly**. Current format: ```...
Having the fix for the issue from #11099 in this PR instead of in a separate commit or PR isn't ideal. Since there #11193 was opened to fix the issue...
workspace inheritance was [stabilized](https://github.com/rust-lang/cargo/pull/10859) and is set to be released in Rust `1.64` on [September 22, 2022](https://forge.rust-lang.org/#current-release-versions)