"window_control_placeholder_support.css" causes window controls to be in top middle

[aviadhaham]

trafficstars

Issue

---

After updating to Firefox 1.33, the issue started, the window controls, instead of being top left as always, they started being at the top, but in middle ("floating" over the URL bar in my case).

After debugging using the devtools, I found the issue is here, in the marked element:

Solution

I took the latest version of the CSS file (github), added the below CSS, and it solved it:

/* To fix the weird position of the window controls from the middle to the left */
#TabsToolbar {
  justify-content: normal !important;
}

@MrOtherGuy If that's good for you, I can create a PR. I wanted to share first about the issue.

[MrOtherGuy]

I'd rather not touch window_control_placeholder_support.css at all anymore. It should not be used in Firefox 133 anymore. For styles that did depend on it there are now better ways to do things.

[matru]

I'd rather not touch window_control_placeholder_support.css at all anymore. It should not be used in Firefox 133 anymore. For styles that did depend on it there are now better ways to do things.

What's the alternative way to handle this then? Simply commenting out window_control_placeholder_support.css will not work.

[MrOtherGuy]

Look up a "_v2" variant of whatever style you were using that required window_control_placeholder_support and simply use that.

If there isn't one then let me know.

[matru]

Look up a "_v2" variant of whatever style you were using that required window_control_placeholder_support and simply use that.

If there isn't one then let me know.

I still have the windows controls in the middle, and from inspecting further the only thing I am noticing right now that might cause the issue is hide_tabs_toolbar_osx, I see that the non-osx one was updated, but this one isn't.

[MrOtherGuy]

There isn't need for separate osx style anymore - just use hide_tabs_toolbar_v2.css

[matru]

perfect, thanks!