firefox-csshacks
firefox-csshacks copied to clipboard
MrOtherGuy
Update window_control_placeholder_support.css to account for number of buttons when using GTK window controls
Replace -moz-gtk-csd-available check with separate conditions for each button and set --uc-window-control-width according to the number of buttons available. This is done to adjust layout to GNOME's titlebar buttons settings including the default which has only close button enabled
This is definitely what we should do, except that surely the width can't be 0px when there is one button there, and 40px if there is two.
Until now I've used 84px for three buttons, so I'd guess that sane values would be 28px, 56px and 84px or something along those lines.
I kinda thought so myself with 0px but for some reason it seems to work (1st screenshot) though I don't exactly know why
28px might be a bit wide
And also tried 9px which ended up looking the closest to what gtk4 has
The second image actually looks as intended.
The buttons are supposed to be separated from the menu by width defined by --uc-window-drag-space-post in window_control_placeholder_support.css. It's purpose is to create space close to window controls where you can drag window from. This kind of space exists in tabs toolbar as well and we want it to exist even if tabs toolbar itself is gone.
But yes you can just set that variable to 0px if you don't want such space.
Hey, just to let you know, I did (finally) add support for variable number of caption buttons in the latest patch. So, I'm closing this pull request as it's no longer relevant. Thanks for the idea though!