firefox-csshacks icon indicating copy to clipboard operation
firefox-csshacks copied to clipboard

floating_findbar_on_top has a white background, even with a dark theme

Open BlueVulture opened this issue 2 years ago • 2 comments
trafficstars

Name Firefox Version 119.0 Build ID 20231019122658

I'm not entirely sure when this began, would say sometime last week, but the findbar is just white. I removed the custom css, and it goes back to normal.

image

The culprit is this line https://github.com/MrOtherGuy/firefox-csshacks/blob/2b284ede80f630646d311ae7ebed48d6bac2bcb7/chrome/floating_findbar_on_top.css#L35

For some reason, even though I have the dark theme enabled (on my entire computer), --lwt-accent-color is white. For now I've just changed that to a solid color, which works for me.

I tried changing it to --toolbar-bgcolor, but that just makes it transparent.

BlueVulture avatar Oct 29 '23 09:10 BlueVulture

This seems to be exactly the same as #315 - basically only version 119 is broken and only with default theme.

Pretty much every style that is using var(--toolbar-bgcolor) might be broken a bit to some extent with default theme. Kinda annoying because a workaround is not required in Firefox 120 anymore for this.

MrOtherGuy avatar Oct 29 '23 10:10 MrOtherGuy

I've added a workaround as part of a6f9e49d1226d7c1e17e412f38daa18a6bcaa8d0 so that style should now work. But there are still some other styles that are probably broken a bit...

MrOtherGuy avatar Oct 29 '23 10:10 MrOtherGuy