firefox-csshacks icon indicating copy to clipboard operation
firefox-csshacks copied to clipboard

Figure out a way to transition page-info-icons better

Open ghost opened this issue 3 years ago • 7 comments

I couldn't find an existing stylesheet for this, so I guess this is a feature request...

Can you please make it possible to autohide the icons/buttons at the start/left of the URL bar? This would include the tracking protection button and identity box, possibly others:

image

This is harder than hiding the page action buttons, since there's no common wrapper for these. However I was wondering if it'd work to instead move the URL itself over to the left (over the top of the icons), then back to normal on hover...?

ghost avatar Nov 28 '21 10:11 ghost

That's a good idea probably. I have created urlbar_icons_on_hover.css for this. It would be great if it was possible to force sharing indicators like sharing screen or microphone be visible but it doesn't look like that would work.

MrOtherGuy avatar Nov 28 '21 13:11 MrOtherGuy

Wow, thanks for that! It works well, except that when used in conjunction with page_action_buttons_on_hover.css the transition durations are different. Here's a PR to fix that: https://github.com/MrOtherGuy/firefox-csshacks/pull/158

Not sure if it's actually needed though, as it seems to not use a transition at all...?

ghost avatar Nov 28 '21 22:11 ghost

What doesn't seem to use transition?

MrOtherGuy avatar Nov 29 '21 06:11 MrOtherGuy

Peek 2021-11-29 21-07

The icons on the left don't seem to 'slide' in or out, they just appear/disappear. Whereas the one on the right slides in and out.

ghost avatar Nov 29 '21 10:11 ghost

Oh okay, the longer transition was actually used exactly for that. Now its width changes so fast that you can barely see any transition. Because the 100ms transition time is from 300px -> 0px not from <whatever-the-width-of-the-icon-is> -> 0px - so if you make the duration 1000ms it should clearly animate.

I admit, the styling should probably be done quite differently if you want the visual transition-durations to match - but just using a longer transition-duration is nice and easy proxy in the mean time.

MrOtherGuy avatar Nov 29 '21 10:11 MrOtherGuy

Ah yes, I see now. Sorry about that. Up to you if you want to revert the transition change then. Happy to close this issue otherwise.

ghost avatar Nov 29 '21 10:11 ghost

I'll keep this open for now and just make this issue about making the transition duration more sane. I just don't know at the moment what would be a good way to do this since the icons are not necessarily the same width with each other.

MrOtherGuy avatar Nov 29 '21 10:11 MrOtherGuy