xmr-node-proxy icon indicating copy to clipboard operation
xmr-node-proxy copied to clipboard

Email feature request

Open bobbieltd opened this issue 7 years ago • 6 comments

I guess it's simple for you to add email notifications (like in nodejs-pool). Very useful.

bobbieltd avatar Apr 23 '18 14:04 bobbieltd

Do you think that users of XNP are pro enough to setup mailgun account API? I think it will be maybe 1-2 users of this feature.

MoneroOcean avatar Apr 24 '18 07:04 MoneroOcean

Totally agree ! What about our pool provide free emails for proxy users if they mine at our pool. Let proxy sending email request to the pool. With backend pool support, proxy will have email feature.

bobbieltd avatar Apr 24 '18 08:04 bobbieltd

This is quite interesting idea. Will think about it.

MoneroOcean avatar Apr 24 '18 08:04 MoneroOcean

+Idea (own provider):

How about nodemailer module, load config from config.json and then trigger nodemailer here? Something like this. Sorry for my 0 knowledge about NodeJS.

var notifier = nodemailer.createTransport({
  service: 'provider',
  auth: {
    user: '[email protected]',
    pass: 'password'
  }
});

var notifierOptions = {
  from: '[email protected]',
  to: '[email protected]',
  subject: 'Notification from XNP.',
  text: 'Worker ' + workerData.workerID + ' stopped hashing.'
};

and

notifier.sendMail(notifierOptions);

djfinch avatar Apr 24 '18 19:04 djfinch

Thanks for suggestion. Yes, it is good point to add email notification. Need to sleep over safe implementation of this. Need to be careful since giving (indirect) access to pool email API can be exploited more easily since in simple miner case they "earn" to have email notification only if they submit at least one share of work.

MoneroOcean avatar Apr 26 '18 06:04 MoneroOcean

@MoneroOcean You can check proxy’s wallet address shares. If number of shares is high enough, give it free emails. I don’t think people will abuse it. Too many emails = spamming = annoying. Emails should be sent per hour or per two hour.

bobbieltd avatar Apr 26 '18 11:04 bobbieltd