ospgrillage icon indicating copy to clipboard operation
ospgrillage copied to clipboard

fix gh page workflow

Open justinngan92 opened this issue 1 year ago • 2 comments

  • remove sphinx action

justinngan92 avatar Sep 20 '24 02:09 justinngan92

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.28%. Comparing base (cc0fb4a) to head (8ac2d27). Report is 8 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   87.30%   87.28%   -0.03%     
==========================================
  Files          16       16              
  Lines        4522     4514       -8     
==========================================
- Hits         3948     3940       -8     
  Misses        574      574              

see 8 files with indirect coverage changes

codecov-commenter avatar Sep 20 '24 02:09 codecov-commenter

Removed sphinx-action (uses: ammaraskar/sphinx-action@master) and instead use build command directly.

The workflow successfully run up to the push action - which failed because not owner of repo.

Next commit will revert the workflow to on: pull_request branches: [ gh-pages ]

justinngan92 avatar Sep 20 '24 03:09 justinngan92

I think the doc build dependecies should be in a requirements.txt like for pycba??

https://github.com/ccaprani/pycba/blob/main/docs/requirements.txt

Is this what you are refering to?

https://github.com/MonashSmartStructures/ospgrillage/blob/main/docs/requirements.txt

justinngan92 avatar Apr 16 '25 02:04 justinngan92

Might not need pydata-sphinx-theme in yml but accepting for now.

ccaprani avatar May 02 '25 07:05 ccaprani