FHist.jl icon indicating copy to clipboard operation
FHist.jl copied to clipboard

[WIP] Add advanced plotting recipies

Open mmikhasenko opened this issue 1 year ago • 4 comments

Closes #126

New Plots.jl recipe makes it easy to plot a curve over a histogram. There are two new functionality:

  • plot(model::Function, WithData(h)): to adjust normalization of the model taking into account the bin width

  • curvedfitwithpulls(h, best_model): a plot recipe for the histogram, model curve and pulls.

  • [ ] Tests are passing

  • [ ] Documentation is updated

mmikhasenko avatar Nov 07 '24 16:11 mmikhasenko

I'm a bit confused to what do you want.

Do you want to add a Plots.jl only recipe to this package? And the fitting too?

Moelf avatar Nov 07 '24 17:11 Moelf

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (ca99f99) to head (11c0ceb). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
ext/FHistPlotsExt.jl 0.00% 53 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (ca99f99) and HEAD (11c0ceb). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (ca99f99) HEAD (11c0ceb)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   77.45%   71.94%   -5.51%     
==========================================
  Files          11       11              
  Lines         825      877      +52     
==========================================
- Hits          639      631       -8     
- Misses        186      246      +60     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 07 '24 17:11 codecov[bot]

Added description to the header. It is a Plots.jl specific recipe. No fitting, just plotting with correct scaling.

mmikhasenko avatar Nov 08 '24 08:11 mmikhasenko

note: within a recipe, the histograms for pulls are plotted with scatter series type. When trying to plot a histogram, issue #123 leads to an error.

mmikhasenko avatar Nov 08 '24 09:11 mmikhasenko