magento2-dockergento
magento2-dockergento copied to clipboard
ModestCoders
Update pre-commit
I've provided a simpler approach to running grumphp inside a docker container. I've provided details to the project itself, for others to see here . I'm sharing this knowledge back with your project, as reviewing how you got it working helped me out.
Hi @ryantfowler Thanks a lot for your PR. Have you tried it when commiting a large bunch of files? I'll give it a try, but I don't remember if we've already tried a similar approach and had issues when the diff was too large. Thanks a lot!
@danielozano I've only been working with this approach in the context of normal development. I'd say the largest set of files would be an initial theme commit. Hopefully that helps.
Sorry @ryantfowler when I try to commit for testing, I just get an error like this one:
docker: Error: No such image: 62a2c063b218ae30c8f8656487771e158671b5d5390791ac578341649d9eb662.
See 'docker run --help'.
And when I debug I see this sentence being executed:
exec docker run --rm -t --volume=/magento/host-root-dir/:./ 62a2c063b218ae30c8f8656487771e158671b5d5390791ac578341649d9eb662 vendor/bin/grumphp './bin/grumphp git:pre-commit' --skip-success-output
So docker run [IMAGE] expects an image identifier, but will not work with a container id docker run CONTAINER_ID
Thank you!
@danielozano my mistake. I've updated the PR. On a side note, if this gets merged in, then Grumphp will officially support this and you could consider leveraging that.