lightllm icon indicating copy to clipboard operation
lightllm copied to clipboard

add flashinfer fused_norm_add op

Open SangChengC opened this issue 2 weeks ago • 1 comments

SangChengC avatar Nov 13 '25 07:11 SangChengC

Summary of Changes

Hello @SangChengC, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant performance optimization by integrating FlashInfer's fused add_rmsnorm operation into the core transformer layer inference. This change aims to accelerate models utilizing RMS normalization by combining the residual addition and normalization steps into a single, highly efficient GPU kernel. The implementation is robust, dynamically checking for FlashInfer availability and the specific normalization type used by the model to ensure correct and optimal application.

Highlights

  • FlashInfer Integration: Integrated FlashInfer's fused_add_rmsnorm operation into the transformer layer inference process for performance optimization.
  • Conditional Optimization: The FlashInfer optimization is applied conditionally, only when FlashInfer is available and the model uses RMS normalization.
  • Normalization Type Detection: Added a norm_type attribute to TransformerLayerWeight to dynamically determine if a model uses RMS norm or Layer norm, enabling precise application of the fused operation.
  • Model Support: Extended the fused normalization logic to various model architectures, including DeepSeek2, Gemma3, and Qwen3-MoE, ensuring broader applicability of the performance enhancement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 13 '25 07:11 gemini-code-assist[bot]