Vanilla-DataTables icon indicating copy to clipboard operation
Vanilla-DataTables copied to clipboard

implement paging and scrollY

Open johanneswilm opened this issue 7 years ago • 4 comments
trafficstars

Hey, there are still some things not entirely clear to me, and I don't know if this is how you would do it, but I tried to stick to your coding style as much as possible and did it in a similar way to how it's done in jQuery Datatables. I worked on the 1.6 rather than the 2.0 branch, give that it wasn't clear to me on which one you working.

Relates to #56 .

johanneswilm avatar Mar 29 '18 12:03 johanneswilm

@Mobius1 One that that was not very clear to me was if it's always the case that this.activeHeadings is the same as this.table.tHead.firstElementChild.children when the table had a tHead. I assumed they are the same, and it works in the test there is, but maybe with other options it works differently? Anyway, have a look.

johanneswilm avatar Mar 29 '18 18:03 johanneswilm

@Mobius1 With these changes applied, it now seems to work in all our views. However, we always only have one table per page, so we don't notice the kind of leakage reported in #58 .

johanneswilm avatar Apr 10 '18 06:04 johanneswilm

@Mobius1 How do you want me to continue to work on this?

johanneswilm avatar Apr 27 '18 14:04 johanneswilm

@Mobius1 Ping! Are you still working on this or would it be better to simply fork and create a new package? I see there are now 5 PRs.

johanneswilm avatar Jul 01 '18 17:07 johanneswilm