RecTools icon indicating copy to clipboard operation
RecTools copied to clipboard

Model configs

Open feldlime opened this issue 1 year ago • 1 comments
trafficstars

Description

  • Added configs to models

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

feldlime avatar Jul 31 '24 12:07 feldlime

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9b3992e) to head (df1fbac). Report is 93 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #170     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        57     +12     
  Lines         2242      3744   +1502     
===========================================
+ Hits          2242      3744   +1502     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 31 '24 12:07 codecov[bot]

Please add that this PR closes two issues #108 and #157

blondered avatar Nov 09 '24 12:11 blondered