RecTools icon indicating copy to clipboard operation
RecTools copied to clipboard

Feature/metricsapp metainfo

Open Gooogr opened this issue 1 year ago • 3 comments
trafficstars

Description

Closes https://github.com/MobileTeleSystems/RecTools/issues/150: add support of scatter plot colors maps based on any model meta-info.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

Gooogr avatar Jun 19 '24 22:06 Gooogr

TODO:

  • [x] Update docstring with metadata example
  • [x] Expand tests
  • [ ] Update .ipynb example (cross-validation)
  • [x] Update changelog

Gooogr avatar Jun 19 '24 22:06 Gooogr

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9b3992e) to head (2d4546c). Report is 68 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #154     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        55     +10     
  Lines         2242      3361   +1119     
===========================================
+ Hits          2242      3361   +1119     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 20 '24 15:06 codecov[bot]

TODO:

  • [x] Improve test coverage for codecov

Gooogr avatar Jun 20 '24 16:06 Gooogr