Mobile-Security-Framework-MobSF icon indicating copy to clipboard operation
Mobile-Security-Framework-MobSF copied to clipboard

[EFR-02]Enterprise Feature Request - False Positive Triaging

Open ajinabraham opened this issue 3 years ago • 1 comments
trafficstars

Describe the Pull Request

Enterprise Feature Request - False positive suppression support

Coverage

  • [x] Android - Code, Manifest
  • [x] iOS - Code
  • [x] iOS Binary
  • [x] Support other params that contribute to score
  • [ ] API + Docs
  • [x] Support for Score/PDF/JSON etc.
  • [ ] Tests

Checklist for PR

  • [ ] Run MobSF unit tests and lint tox -e lint,test
  • [ ] Tested Working on Linux, Mac, Windows, and Docker
  • [ ] Add unit test for any new Web API (Refer: StaticAnalyzer/tests.py)
  • [ ] Make sure tests are passing on your PR MobSF tests

Additional Comments (if any)

DESCRIBE HERE

ajinabraham avatar Jul 25 '22 05:07 ajinabraham

👋 @ajinabraham Thank you for sending this pull request ❤️. Please make sure you have followed our contribution guidelines. We will review it as soon as possible

github-actions[bot] avatar Jul 25 '22 05:07 github-actions[bot]

@matandobr Addressed some of the review comments.

This happened after I deleted a suppression by rule ID

Can you reproduce this reliably/ share steps to reproduce? I cannot reproduce this at my end. I know that there is an edge case where Data tables will fail if the table is not created properly in time.

Also I think the search is a bit weird because you are not splitting the lines, so each search will either return 0, 1, or 2 rows... not so helping I guess

I am not sure I understand you. The search is a feature provided by Data tables itself.

ajinabraham avatar Sep 30 '22 22:09 ajinabraham