mithril.js icon indicating copy to clipboard operation
mithril.js copied to clipboard

The test suite uses our Promise polyfill

Open pygy opened this issue 2 years ago • 1 comments

The logic in ./promise/promise.js picks up the global window defined by the ./tests/test-api.js, doesn't find a Promise implementation, and goes on to use our polyfill instead of native promises.

Adding native promises to ./test-utils/broswerMock.js would solve this regardless of any future change in test loading order.

pygy avatar Jan 24 '23 16:01 pygy

I fixed this in the v2.x branch, along with a perf regression in the test suite.

@StephanHoyer @dead-claudia Do you see this going into next as well?

https://github.com/MithrilJS/mithril.js/commit/ed2365d77d9883d1f617121365d0ac72143935a5

pygy avatar Jan 24 '23 16:01 pygy