mintbase-js icon indicating copy to clipboard operation
mintbase-js copied to clipboard

Add fastnear rpc + new rpcUrl prop

Open rubenmarcus opened this issue 1 year ago • 2 comments
trafficstars

rubenmarcus avatar Jul 12 '24 08:07 rubenmarcus

@CodiumAI-Agent /review

tifrel avatar Jul 19 '24 10:07 tifrel

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Missing Error Handling
The function requestFromNearRpc does not handle network or fetch errors. It is recommended to add error handling to manage cases where the fetch request fails or the network is unreachable.

Inconsistent Parameter Usage
The function callViewMethod inconsistently uses rpcUrl. It should consistently pass rpcUrl to all calls or handle it differently to maintain consistency and avoid potential bugs.

Error Handling
The function fetchBalance should handle possible errors from requestFromNearRpc or when balanceString is not present in the response.

CodiumAI-Agent avatar Jul 19 '24 10:07 CodiumAI-Agent

Ok --- So this branch was never merged and our wallet is depending on it in production.

bh2smith avatar Aug 20 '24 10:08 bh2smith