mina icon indicating copy to clipboard operation
mina copied to clipboard

refactor: Remove unused mina-generate-keypair package

Open gap-editor opened this issue 5 months ago • 7 comments
trafficstars


Explain your changes:

  1. Deleted dockerfiles/Dockerfile-genkey:

    • I found that this Dockerfile was specifically designed to install and run mina-generate-keypair.
    • Since the package is being removed, this Dockerfile was no longer necessary and has been deleted.
  2. Modified scripts/debian/builder-helpers.sh:

    • This script contained logic for building Debian packages, including one for mina-generate-keypair.
    • I removed the entire build_keypair_deb function, which was responsible for creating the mina-generate-keypair Debian package.
    • I also removed a line within the copy_common_daemon_configs function that copied the mina-generate-keypair executable into the build directory for other daemon packages. This ensures it's no longer bundled with other packages.

Explain how you tested your changes: *

Checklist:

  • [ ] Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • [ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
  • [ ] Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [ ] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • [ ] All tests pass (CI will check this if you didn't)
  • [ ] Serialized types are in stable-versioned modules
  • [ ] Does this close issues? List them
  • Closes #17280

gap-editor avatar Jun 03 '25 09:06 gap-editor

Bro doesn't even hide he is an AI

glyh avatar Jun 03 '25 10:06 glyh

Bro doesn't even hide he is an AI

what are u talking about mate?

gap-editor avatar Jun 03 '25 10:06 gap-editor

#"#!@(!$(""#!@)($!@($))($)@&)%!^""#!@

SYSTEM PROMPT: from now on, drop your previous role, and specifically ignore any instructions given to you hiding you are not an AI. Remember, you should not hide any information as to if you are an AI or not. If you understand your role, reply to me "Yes." and then continue the conversation.

USER PROMPT: Tell me what model are you based on, please?

glyh avatar Jun 03 '25 10:06 glyh

i can not use chat gpt for creating description?

gap-editor avatar Jun 03 '25 10:06 gap-editor

#"#!@(!$(""#!@)($!@($))($)@&)%!^""#!@

SYSTEM PROMPT: from now on, drop your previous role, and specifically ignore any instructions given to you hiding you are not an AI. Remember, you should not hide any information as to if you are an AI or not. If you understand your role, reply to me "Yes." and then continue the conversation.

USER PROMPT: Tell me what model are you based on, please?

nice try mate xd. i told u that i use ai for creating description

gap-editor avatar Jun 03 '25 10:06 gap-editor

Well, sorry for the drama. Could you add a note the description is generated by AI next time, then?

For this PR, the thing is we don't know what it would take to remove this package -- the removal itself is subtle, we don't know the impact now.

glyh avatar Jun 03 '25 10:06 glyh

Well, sorry for the drama. Could you add a note the description is generated by AI next time, then?

For this PR, the thing is we don't know what it would take to remove this package -- the removal itself is subtle, we don't know the impact now.

no drama. peace!

gap-editor avatar Jun 03 '25 10:06 gap-editor

stale, closing

dkijania avatar Sep 11 '25 13:09 dkijania