mina icon indicating copy to clipboard operation
mina copied to clipboard

Refactor Mina RPCs (compatible)

Open nholland94 opened this issue 1 year ago • 3 comments
trafficstars

This PR refactors the Mina RPC implementations such that they are now in a single unified location and have more shared/less duplicated logic.

The first commit is the largest and most annoying to review, but it mostly moves type definitions around and combines RPC implementations that were split across Mina_networking and Mina_lib. It's intended to have limited behavior changes (the changes that were made are just in standardizing how RPCs are handled). Subsequent commits make more meaningful changes to RPCs, including refactoring the node status system out of the RPC layer (since that was moved over to libp2p_helper some time ago). Further changes will be included in a PR building off of this into develop.

nholland94 avatar Aug 23 '24 17:08 nholland94

!ci-build-me

nholland94 avatar Aug 23 '24 17:08 nholland94

!ci-build-me

nholland94 avatar Aug 23 '24 17:08 nholland94

!ci-build-me

nholland94 avatar Aug 23 '24 18:08 nholland94

!ci-build-me

nholland94 avatar Aug 29 '24 18:08 nholland94

!ci-build-me

mrmr1993 avatar Sep 01 '24 23:09 mrmr1993