mina icon indicating copy to clipboard operation
mina copied to clipboard

Apply caqti patch

Open dkijania opened this issue 1 year ago • 27 comments

Since Berkeley is safety out, we can merge caqti update to our codebase and do not keep it as patch .

In this PR i also fixed toolchain issue which didn't build focal and GIT LFS was also making some trouble

dkijania avatar Jul 29 '24 19:07 dkijania

!ci-build-me

dkijania avatar Jul 29 '24 19:07 dkijania

!ci-toolchain-me

dkijania avatar Jul 29 '24 19:07 dkijania

!ci-build-me

dkijania avatar Jul 30 '24 10:07 dkijania

!ci-build-me

dkijania avatar Jul 31 '24 14:07 dkijania

!ci-build-me

dkijania avatar Aug 13 '24 21:08 dkijania

!ci-build-me

dkijania avatar Aug 26 '24 07:08 dkijania

!ci-build-me

dkijania avatar Aug 26 '24 22:08 dkijania

!ci-toolchain-me

dkijania avatar Aug 26 '24 22:08 dkijania

!ci-build-me

dkijania avatar Aug 27 '24 20:08 dkijania

!ci-nightly-me

dkijania avatar Aug 27 '24 20:08 dkijania

!ci-build-me

dkijania avatar Sep 02 '24 17:09 dkijania

!ci-nightly-me

dkijania avatar Sep 03 '24 08:09 dkijania

!ci-toolchain-me

dkijania avatar Sep 04 '24 11:09 dkijania

!ci-build-me

dkijania avatar Sep 04 '24 17:09 dkijania

!ci-build-me

dkijania avatar Sep 05 '24 17:09 dkijania

!ci-build-me

dkijania avatar Sep 09 '24 19:09 dkijania

!ci-build-me

dkijania avatar Sep 10 '24 15:09 dkijania

!ci-build-me

dkijania avatar Sep 13 '24 08:09 dkijania

!ci-nix-me

georgeee avatar Sep 13 '24 13:09 georgeee

Something is still off with the toolchain

Nix build succeeds: https://buildkite.com/o-1-labs-2/mina-nix-experimental/builds/33#0191eb83-0f41-4863-8f15-9dd8092a68b7

georgeee avatar Sep 13 '24 13:09 georgeee

!ci-build-me

dkijania avatar Sep 16 '24 18:09 dkijania

!ci-build-me

dkijania avatar Sep 17 '24 07:09 dkijania

!ci-build-me

dkijania avatar Sep 18 '24 07:09 dkijania

!ci-build-me

dkijania avatar Sep 18 '24 22:09 dkijania

The patch originated in this PR, for reference.

mrmr1993 avatar Sep 19 '24 20:09 mrmr1993

@dkijania could you please make a PR just for the caqti upgrade? and the remainder changes as follow-up?

deepthiskumar avatar Oct 15 '24 22:10 deepthiskumar

@deepthiskumar Sorry, i don't fully understand if you spotted some change that you think is unrelated to caqti update (which i didn't noticie) or you mean to just extract opam.export and toolchain container change?

dkijania avatar Oct 16 '24 08:10 dkijania

this PR

As @mrmr1993 mentioned in the comment, the changes from https://github.com/MinaProtocol/mina/pull/15310 which is to speed up initialization of AN is included. It is in the commit https://github.com/MinaProtocol/mina/pull/15881/commits/c2f4304c58606dc4abbbf8a4b6d1b977a5cf4bb4. There were some reviews on that PR which need to be addressed

deepthiskumar avatar Oct 21 '24 19:10 deepthiskumar

!ci-build-me

dkijania avatar Nov 14 '24 20:11 dkijania

!ci-build-me

dkijania avatar Nov 15 '24 21:11 dkijania