contextualized-topic-models icon indicating copy to clipboard operation
contextualized-topic-models copied to clipboard

Variable naming issues

Open akshaylive opened this issue 1 year ago • 3 comments

I was following the reparameterization code.

During invocation, the variable posterior_log_sigma is incorrectly named. It's supposed to be posterior_log_variance. Similarly, the inf net needs to be renamed to variance instead of sigma.

However, the naming here is accurate.

akshaylive avatar Dec 08 '23 03:12 akshaylive

Thanks, that make sense! Do you want to open a PR for that?

vinid avatar Dec 08 '23 04:12 vinid

I've opened the PR. I haven't actually executed it though. Please review/merge with caution. :)

akshaylive avatar Dec 08 '23 08:12 akshaylive

Please ignore the previous comment - the tests passed.

akshaylive avatar Dec 08 '23 23:12 akshaylive