OpenComputers icon indicating copy to clipboard operation
OpenComputers copied to clipboard

[1.12-Issue] Incompatibility with Valkyrien Skies

Open gatoborrachon opened this issue 4 years ago • 3 comments

Description: When you load Valkyrien Skies and OpenComputers only, you will get this message from the chat: 2021-04-03_15 23 35

and when you build a ValkyrienSkies ship and try to run a computer, the Analyzer will drop this: 2021-04-03_15 29 12 What is in the log: https://pastebin.com/SFrU2nq2

File required: latest.log

Versions: OpenComputers-MC1.12.2-1.7.5.192 valkyrien-skies-1.12.2-1.1.6 valkyrien-skies-control-1.12.2-1.1.1 valkyrien-skies-world-1.12.2-1.0.0

gatoborrachon avatar Apr 03 '21 21:04 gatoborrachon

+I also would like to add that ValkyrienSkies seems to be a bit invasive in what they allow, for example, there was a Server-Side crash between VS and Survival Inc related to RayTrace stuff: https://github.com/Enginecrafter77/SurvivalInc/issues/34

+that issue was easy to solve just by changing how a thing work, maybe the same is happening here. Related Issue: https://github.com/ValkyrienSkies/Valkyrien-Skies/issues/489

gatoborrachon avatar Apr 05 '21 00:04 gatoborrachon

this is definitely a vs issue because of the abandoned oc "compat" module

deltanedas avatar Apr 05 '21 01:04 deltanedas

The issue is that OpenComputers sends packets off the main thread, which requires a call to player.getDistanceSq(), which in Valkyrien Skies is enforced to be on the main thread.

asiekierka avatar Sep 02 '22 09:09 asiekierka