sql-docs icon indicating copy to clipboard operation
sql-docs copied to clipboard

Fix spacing of "-V" command

Open emil-eklund opened this issue 1 year ago • 6 comments

Fixes spacing used in examples for the "-V" (severity) command. Incorrect usage will cause the command to fail.

See earlier discussion: https://github.com/Azure/sql-action/issues/235

emil-eklund avatar Jul 09 '24 07:07 emil-eklund

@emil-eklund : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Jul 09 '24 07:07 prmerger-automator[bot]

Learn Build status updates of commit 9a30ea2:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/tools/sqlcmd/sqlcmd-utility.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

I think this passage is incorrect too, but I've not had the time to verify for all parameters:

Currently, sqlcmd doesn't require a space between the command-line option and the value. However, in a future release, a space may be required between the command-line option and the value.

emil-eklund avatar Jul 09 '24 11:07 emil-eklund

@dlevy-msft

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Jul 09 '24 14:07 Court72

This appears to be an issue with the tool. Will need some time to investigate.

dlevy-msft avatar Jul 10 '24 00:07 dlevy-msft

This appears to be an issue with the tool. Will need some time to investigate.

I agree. But I do also think the documentation should be updated if the following statement is true:

Currently, sqlcmd doesn't require a space between the command-line option and the value. However, in a future release, a space may be required between the command-line option and the value.

emil-eklund avatar Jul 10 '24 08:07 emil-eklund

@emil-eklund Thanks for your patience. We are updating the sqlcmd article in the next business day or so, with the following note.

[!NOTE]
If you use the -i option followed by one or more additional parameters, you must use a space between the parameter and the value. This is a known issue in sqlcmd (Go).

You will still receive contributor credit.

rwestMSFT avatar Feb 06 '25 22:02 rwestMSFT