azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Add "Deploy open-source SpinKube" article to AKS docs

Open ThorstenHans opened this issue 1 year ago • 4 comments

This PR adds an article to the AKS documentation explaining how users could deploy open-source SpinKube to their AKS cluster

ThorstenHans avatar Jul 04 '24 08:07 ThorstenHans

Learn Build status updates of commit 0a47f03:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/aks/deploy-spinkube.md :bulb:Suggestion Details

articles/aks/deploy-spinkube.md

  • Line 7, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ThorstenHans' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

prmerger-automator[bot] avatar Jul 04 '24 08:07 prmerger-automator[bot]

@ThorstenHans

Thanks for your pull request. A member of the content team will review it.

Court72 avatar Jul 04 '24 15:07 Court72

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Jul 04 '24 15:07 Court72

@squillace you may want to review as well.

devigned avatar Jul 16 '24 18:07 devigned

Thanks for the reviews wasn't aware of the interactive az snippets 👍🏻

ThorstenHans avatar Jul 18 '24 16:07 ThorstenHans

@ThorstenHans are interested some help addressing this feedback. I'm happy to help push this PR forward.

devigned avatar Aug 16 '24 17:08 devigned

@devigned, @schaffererin

Can you review this old PR and determine whether it needs to be closed or moved into the private repo for review and merge?

Court72 avatar Aug 27 '24 15:08 Court72

@Court72 I will update this PR by EOW

Sorry for the ultra long delay, but I was out for a couple of weeks

ThorstenHans avatar Aug 27 '24 15:08 ThorstenHans

Learn Build status updates of commit 34277e2:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/aks/deploy-spinkube.md :bulb:Suggestion Details

articles/aks/deploy-spinkube.md

  • Line 7, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ThorstenHans' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

prmerger-automator[bot] avatar Aug 29 '24 11:08 prmerger-automator[bot]

@devigned Finally, I updated the PR thanks for the amazing feedback

ThorstenHans avatar Aug 29 '24 11:08 ThorstenHans

Learn Build status updates of commit 7508454:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/aks/deploy-spinkube.md :bulb:Suggestion Details

articles/aks/deploy-spinkube.md

  • Line 7, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ThorstenHans' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

prmerger-automator[bot] avatar Aug 29 '24 11:08 prmerger-automator[bot]

Learn Build status updates of commit 10f30d6:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/aks/deploy-spinkube.md :bulb:Suggestion Details

articles/aks/deploy-spinkube.md

  • Line 7, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ThorstenHans' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

prmerger-automator[bot] avatar Aug 29 '24 11:08 prmerger-automator[bot]

Learn Build status updates of commit a7b7451:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/aks/deploy-spinkube.md :bulb:Suggestion Details

articles/aks/deploy-spinkube.md

  • Line 7, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ThorstenHans' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

prmerger-automator[bot] avatar Sep 13 '24 08:09 prmerger-automator[bot]

I sent an email to the content owners today.

Court72 avatar Sep 17 '24 15:09 Court72

Awesome article. I made some comments to here and there but the more important things I wanna see changings are

  1. specifying exact versions for the tools, incouding helm charts and components, are important for repro.
  2. there are many concepts throw out in this article, but I'd like seeing a "Big Picture" description of why these matter to developers
  3. Perhaps linking a troubleshooting guide at the end helps
  4. use ACR instead of ttl.sh

I've pushed a couple of commits to the PR. Would be great to get another review on the updated article.

ThorstenHans avatar Sep 23 '24 13:09 ThorstenHans

Learn Build status updates of commit d64f9b5:

:warning: Validation status: warnings

File Status Preview URL Details
articles/aks/deploy-spinkube.md :warning:Warning Details

articles/aks/deploy-spinkube.md

  • Line 14, Column 360: [Warning: file-not-found - See documentation] Invalid file link: 'wasm-component-model'.
  • Line 37, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'node-js'.
  • Line 7, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'ThorstenHans' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@devigned @schaffererin - This PR is ready for your review.

ShannonLeavitt avatar Oct 02 '24 14:10 ShannonLeavitt

@ThorstenHans @jsturtevant - AKS content now resides in https://github.com/MicrosoftDocs/azure-aks-docs. Please resubmit your changes there.

tynevi avatar Oct 04 '24 18:10 tynevi

@tynevi @jsturtevant I created the PR over in the new repo (https://github.com/MicrosoftDocs/azure-aks-docs/pull/57)

ThorstenHans avatar Oct 09 '24 07:10 ThorstenHans