did-btc-spec icon indicating copy to clipboard operation
did-btc-spec copied to clipboard

Incorrect `id` properties in examples

Open brianorwhatever opened this issue 1 year ago • 1 comments

In the DID document examples the id properties aren't correct. The top level id should be the DID itself and not just the txref. The other items are also incorrect as they use the txref instead of the DID as well.

brianorwhatever avatar May 02 '24 17:05 brianorwhatever

Thanks for catching this, that's right. It was just an oversight in my part when constructing the examples.

sangaman avatar May 02 '24 17:05 sangaman

I am closing this as it was addressed.

LeoBeb avatar Jul 23 '24 15:07 LeoBeb

No it was not. The id parameter in the linked example is not a proper uri. It should be the did itself

brianorwhatever avatar Jul 23 '24 18:07 brianorwhatever

Reopening until the PR is approved and merged.

LeoBeb avatar Jul 23 '24 19:07 LeoBeb

Merged the changes from #14. If further changes are required, please create a new PR directly. Thank you.

LeoBeb avatar Aug 09 '24 19:08 LeoBeb