dart-redux-remote-devtools icon indicating copy to clipboard operation
dart-redux-remote-devtools copied to clipboard

Add support for "commit" action

Open zbarbuto opened this issue 5 years ago • 4 comments
trafficstars

The "commit" button in redux dev tools usually clears the action list and commits state.

image

However when clicking with Flutter we get "Unknown commans (sic): COMMIT. Ignoring"

image

zbarbuto avatar Jul 28 '20 23:07 zbarbuto

What does "commit state" mean in this context? The action list is implemented entirely on the remote devtools server side - what is the flutter app supposed to do with the commit command?

MichaelMarner avatar Jul 29 '20 00:07 MichaelMarner

Should devtools middleware dispatch a save action?

MichaelMarner avatar Jul 29 '20 00:07 MichaelMarner

That is probably the solution. I use the "commit" button to just clear the action log personally but the actual purpose of it is to save the current state for the "revert" button to jump to.

zbarbuto avatar Jul 29 '20 05:07 zbarbuto

ok then it looks like devtools server is expecting a response back from us to indicate the commit occurred. I'll have a look into the source code and find out what we're supposed to send.

MichaelMarner avatar Jul 29 '20 12:07 MichaelMarner