Michael Currin

Results 251 comments of Michael Currin
trafficstars

I made a draft PR #203 which I must test locally still.

I'm stuck with this. @AlfredoRamos in your comment above, you said a bad login returns ```ruby {:message=>"Not Found", :documentation_url=>"https://docs.github.com/rest/reference/orgs#get-an-organization"} ``` But when running unit tests as is, I see that...

Regarding my suggestion to add a test case to handle owner_info method returning `{}` for bad username. I found that there is no test coverage on the `owner_info` method. I...

Thanks, looks good!

Correct. One should only provide the path to the file (this relative to project root) and the function should figure what the browser path should be.

Here is the full output when I ran locally. Just the URLs matter. Note that I don't have author set up on my site. ```xml Jekyll Blog Demo Starter for...

Also by the way it looks weird that the live atom.xml page in your linked site uses a completely different format. e.g. `feed` and `entry`, which are not in the...

I was confused at this line, because it didn't give any example. [lib/generators/blog/index.js](https://github.com/vuepress/create-vuepress-site/blob/fc5920ebd33b48a1965c8bca3bb0dbc3b7ef8ed5/lib/generators/blog/index.js#L24) ``` What's the repo of your project? ``` It made me wonder - should I enter `my-app`,...

On further inspection, I see the value actually gets used here in the template: [lib/generators/blog/templates/package.json](https://github.com/vuepress/create-vuepress-site/blob/fc5920ebd33b48a1965c8bca3bb0dbc3b7ef8ed5/lib/generators/blog/templates/package.json#L10) ``` "/" ``` Based on working with `package.json`, I'd expect the finished value to be...

This issue was created as general improvement of code and documentation. You have a very specific error, possibly specific to your OS or the fields you are entering. Perhaps you...