Micha Reiser

refactor(rome_formatter): Remove `next_index` from `Queue`

4

## Summary This refactor simplifies the `Queue` implementation by removing the `next_index` state and instead updating the slice to only contain the remaining items. ## Test `cargo test` ## Performance...

📎 Formatter: Number literal separators

1

### Description Consistently format separators in number literals [example](https://play.rome.tools/?code=+1_1%3B%0A+1_1.1_1%3B%0A+0o1_1%3B%0A+0o0_11%3B%0A+1.1_0_1e1%3B%0A-1.1_0_1e1%3B%0A-0.1_1%3B%0A%2B1.1_0_1E1%3B%0A%2B.1_1%3B%0A+0x1_1%3B%0A-0xa_1%3B%0A+0xa_1%3B%0A%2B0xA_1%3B%0A+0b01_1%3B%0A+0b0_1_1%3B&lineWidth=80&indentStyle=tab&quoteStyle=single&quoteProperties=as-needed&indentWidth=2&sourceType=module&enabledNurseryRules=true&typescript=true&jsx=true#IAAxAF8AMQA7AAoAIAAxAF8AMQAuADEAXwAxADsACgAgADAAbwAxAF8AMQA7AAoAIAAwAG8AMABfADEAMQA7AAoAIAAxAC4AMQBfADAAXwAxAGUAMQA7AAoALQAxAC4AMQBfADAAXwAxAGUAMQA7AAoALQAwAC4AMQBfADEAOwAKACsAMQAuADEAXwAwAF8AMQBFADEAOwAKACsALgAxAF8AMQA7AAoAIAAwAHgAMQBfADEAOwAKAC0AMAB4AGEAXwAxADsACgAgADAAeABhAF8AMQA7AAoAKwAwAHgAQQBfADEAOwAKACAAMABiADAAMQBfADEAOwAKACAAMABiADAAXwAxAF8AMQA7AA==) ## Test Cases * `js/literal-numeric-separator/test.js` * `js/literal/number.js`

🐛 Formatter: String escapes

1

### Environment information ```bash main (3263f956fcc27bedc1c7d60fa25473cc42f2abf7) ``` ### What happened? 1. Open [this playground](https://play.rome.tools/?code=%2F%2F+Not+for+directives%0A%22%5C%5C%5C%24%5C%7B%22%3B%0A%0Alet+a+%3D+%22%5C%5C%5C%24%5C%7B%22%3B%0A%0Alet+snipped+%3D+%27%5Cn++%5C%22%24%7B1%3A3000%7D%22%3A+%7B%5Cn++++%5C%22label%22%3A+%22%24%7B2%3AApplication%7D%22%2C%5Cn++++%5C%22onAutoForward%22%3A+%22%24%7B3%3AopenPreview%7D%22%5Cn++%7D%5Cn%27%3B%0A%0Aresult.push%28%27%5C%5C%5C%27%27%29&lineWidth=80&indentStyle=tab&quoteStyle=double&quoteProperties=as-needed&indentWidth=2&sourceType=module&enabledNurseryRules=true&typescript=true&jsx=false#LwAvACAATgBvAHQAIABmAG8AcgAgAGQAaQByAGUAYwB0AGkAdgBlAHMACgAiAFwAXABcACQAXAB7ACIAOwAKAAoAbABlAHQAIABhACAAPQAgACIAXABcAFwAJABcAHsAIgA7AAoACgBsAGUAdAAgAHMAbgBpAHAAcABlAGQAIAA9ACAAJwBcAG4AIAAgAFwAIgAkAHsAMQA6ADMAMAAwADAAfQAiADoAIAB7AFwAbgAgACAAIAAgAFwAIgBsAGEAYgBlAGwAIgA6ACAAIgAkAHsAMgA6AEEAcABwAGwAaQBjAGEAdABpAG8AbgB9ACIALABcAG4AIAAgACAAIABcACIAbwBuAEEAdQB0AG8ARgBvAHIAdwBhAHIAZAAiADoAIAAiACQAewAzADoAbwBwAGUAbgBQAHIAZQB2AGkAZQB3AH0AIgBcAG4AIAAgAH0AXABuACcAOwAKAAoAcgBlAHMAdQBsAHQALgBwAHUAcwBoACgAJwBcAFwAXAAnACcAKQA=) 2. Observe how Prettier removes the unnecessary escapes in front of `$`, `"`, `'` and `{`...

### Real world usages https://github.com/ant-design/ant-design/blob/master/components/list/Item.tsx#L111-L125 ### What happened? 1. Open [the playground](https://play.rome.tools/?code=actions.map%28%28action%29+%3D%3E%0A%09%09%09%09%28%0A%09%09%09%09%09%2F%2F+eslint-disable-next-line+react%2Fno-array-index-key%0A%09%09%09%09%09%3Cli%3E%0A%09%09%09%09%09%09%7Baction%7D%0A%09%09%09%09%09%09%0A%09%09%09%09%09%3C%2Fli%3E%0A%09%09%09%09%29%2C%0A%29&lineWidth=80&indentStyle=tab&quoteStyle=double&quoteProperties=as-needed&indentWidth=2&sourceType=module&enabledNurseryRules=true&typescript=true&jsx=true#YQBjAHQAaQBvAG4AcwAuAG0AYQBwACgAKABhAGMAdABpAG8AbgApACAAPQA+AAoACQAJAAkACQAoAAoACQAJAAkACQAJAC8ALwAgAGUAcwBsAGkAbgB0AC0AZABpAHMAYQBiAGwAZQAtAG4AZQB4AHQALQBsAGkAbgBlACAAcgBlAGEAYwB0AC8AbgBvAC0AYQByAHIAYQB5AC0AaQBuAGQAZQB4AC0AawBlAHkACgAJAAkACQAJAAkAPABsAGkAPgAKAAkACQAJAAkACQAJAHsAYQBjAHQAaQBvAG4AfQAKAAkACQAJAAkACQAJAAoACQAJAAkACQAJADwALwBsAGkAPgAKAAkACQAJAAkAKQAsAAoAKQA=) 2. Observe how Rome formats the opening `(` on a new line whereas prettier keeps it on the...

📎 Batch Mutation: Remove token

4

### Description I'm currently working on a pre-processing step in the formatter that removes all parenthesized expressions and I use the `BatchMutation` to do the job. One use case that...

🐛 Failing LSP requests after Format on save

2

### Environment information ```bash * v0.8.0 ``` ### What happened? just noticed a bug? in the lsp server. when i do typescript renames or vscode replace-on-files, it will attempt to...

### Environment information ```block @rometools/[email protected] ``` ### What happened? 1. npm i @rometools/backend-jsonrpc Imports fail because the `dist` folder is missing ``` ❯ ls .\node_modules\@rometools\backend-jsonrpc\ Directory: C:\Users\Micha\git\rome-test\node_modules\@rometools\backend-jsonrpc Mode LastWriteTime Length...

☂️ Sort imports

13

### Description Today's editors have very good support for automatically adding imports but do so by adding them at the end of the import statements (or specifiers). The result is...

📎 Exit with error if Rome finds no files

1

### Description The rome commands `rome format`, `rome check`, and `rome ci` should exit with an error code if Rome didn't find any supported files.

🐛 Playground: JSX always enabled

2

### Environment information ### What happened? * Open [Playground](https://play.rome.tools/?code=%2F%2F+chars%3C%2F%5E%5Cw*%2F.exec%28str%29%5B0%5D.length%3B%0A%0Afunction+a%28%29+%7B%0A++return+%3Ctest%3Ea%3C%2Ftest%3E%0A%7D&lineWidth=80&indentStyle=tab&quoteStyle=double&quoteProperties=as-needed&trailingComma=all&indentWidth=2&sourceType=module&enabledNurseryRules=true&typescript=false&jsx=false#LwAvACAAYwBoAGEAcgBzADwALwBeAFwAdwAqAC8ALgBlAHgAZQBjACgAcwB0AHIAKQBbADAAXQAuAGwAZQBuAGcAdABoADsACgAKAGYAdQBuAGMAdABpAG8AbgAgAGEAKAApACAAewAKACAAIAByAGUAdAB1AHIAbgAgADwAdABlAHMAdAA+AGEAPAAvAHQAZQBzAHQAPgAKAH0A) * The file parses correctly regardless if the JSX setting is enabled or not ### Expected result * There should be...