Micha Reiser

Results 794 comments of Micha Reiser

I can see how this would be very useful to set up a new project.

Hmm interesting. It seems that just including vendored file system causes a 60% perf regression because dropping it (the Zip has a ton of metadata) is so expensive.

> I was wondering about using a Lazy static variable for it, since it's immutable read-only data: Hmm yeah, but we would also need to make it lazy in `Program`...

> I don't think Program would need to own a reference to it if it was just a module-level static variable. Code that needs to lookup a file in the...

> I thought we agreed that using --custom-typeshed-dir and the MemoryFileSystem was sufficient for mocking out typeshed in test I understood that we agreed on that the ability to create...

I'll wait with merging to give @carljm a chance to look at it as well.

Thanks @Alex-ley-scrub for your interest. > > @charliermarsh I know you said this on the isort meta issue https://github.com/astral-sh/ruff/issues/6190#issuecomment-1664881638: > > I'm open to contributions for additional isort options, but...

Thanks for the very detailed issue! I had a quick look at the code and I can confirm that paths are always relative to the root directory. https://github.com/astral-sh/ruff/blob/72257328591825b7068f4f31a88f8f975ddc538b/crates/ruff_workspace/src/configuration.rs#L486-L519 I'm not...

@mihirsamdarshi, I would prefer to hear @charliermarsh's opinion first. I'm not very familiar with that part of Ruff and the configuration schema is kind of complicated.

Yes. Thanks for implementing it. It works like a charm. Oh that's an interesting query! I so far only tracked downloads by uv version (our users are really up to...