Micha Reiser

Results 768 comments of Micha Reiser

I'm generally in favor of changing our semantics to match `gitignore` because it is a well-understood format and it makes copying patterns from `gitignore` to the ruff settings easier. It...

I'll close this PR because there's no clear path of what needs to be done to merge it. We can continue the discussion in the linked issue.

I don't think this requires a minor release, considering that the change is gated behind preview mode.

Thanks for reporting and opening a new issue. I think we didn't make an explicit decision, but we merged the improvements we had to include them in 0.1.3 Rules and...

> I get that this way of thinking is a bit changed because of the --fix flag, but still I believe it's more appropriate to have a pipeline with formatting...

Yeah, some rules have this check, but not all of them. However, all fixes that remove (or change code) may reduce the length of lines, possibly causing reformats.

I hear your feedback and I see how `ISC001` is useful even when used with the formatter. The issue is on my to do list I just haven't gotten around...

One option for addressing this issue is to change our formatter, see https://github.com/astral-sh/ruff/issues/9457. However, there's a caveat. The new formatting would be non-reversible and I'm undecided if we should accept...

I agree that the `flake8-quotes.multiline-quotes` should not be shown. However, the option `quote-style: "preserve"` does not resolve the incompatibility to `ISC001` as you can see here https://play.ruff.rs/569c1110-6903-4622-8694-157b243ea73d where the second...

@tibor-reiss I extracted the first breaking change into its own PR and ship it as part of 0.3. We want to wait a little longer with the other options because...