Micha Reiser
Micha Reiser
I think there's one issue that we might need to look into and it's that the visitor will cross function boundaries when searching for `await` and `yield`, resulting in false...
@plredmond I think there are only two cases where this is relevant: classes and functions. You could extend your visitor to handle `visit_stmt explicitly` and traverse classes and functions manually...
IMO, `unused-async` is easier to understand than spurious (which I mainly associate with threading). It also fits well into other rules that catch "unused" syntax.
@plredmond I'm not entirely sure if that's what you mean but you can test if you're inside a class by using ``` // Assignments in class bodies are attributes (e.g.,...
Thanks for the detailed write up. Yes, we do have plans to add checks like this in the future when we work on adding more static analysis (type checking like)...
Do you think the rule could be generalized to disallow method calls on any object defined in a context expression after the `with` statement?
Hi @DavidBuchanan314 If I understand correctly, this is about formatting hex number literals like `0xEF`? I'm asking because Ruff normalizes hex numbers in string literals to lowercase [Playground](https://play.ruff.rs/57e30c6a-4d5e-4227-818a-d0c9dbe25d87) My preference...
> I had the same thought: https://github.com/charliermarsh/ruff-lsp/pull/76#issuecomment-1454257946 Oh nice, I didn't know about this. Thanks for cross-referencing! > It does feel much cleaner, however these are not regular fixes (+...
@snowsignal do you think this issue is still relevant after your new LSP implementation?
I think this is the same as https://github.com/astral-sh/ruff/issues/8360