Micha Reiser

How does your setup look like? Do you use `--diff` or `--check`? The formatter already exits with 0 when not using `--check` or `--diff`. How do you detect changes when...

> I already use `--check` and I know the formatter exits 0 without it. What I'm suggesting is a way to make it format _and_ exit non-zero if anything changed...

Oh sorry. I misunderstood you. If I understand you correctly, you're asking that `ruff format --check` exits with a non-zero exit code if it would reformat any files but it...

@noamraph I'm trying to understand your use case and I'm sorry if this is obvious but my bash knowledge is rather terrible :sweat: What I understand from the script is...

I think this is the same root cause as https://github.com/astral-sh/ruff/issues/3791#issuecomment-1489722670 The difference is that you're building from source. So you would have to set the env variable yourself as far...

Thanks for opening this issue. We'll need to look at this holistically to ensure the formatting is consistent. E.g. how should attributes be broken in binary expressions? Should this style...

@hoel-bagard I try to take a look on Monday. I've a lot of catch up to do on PRs and I'm, unfortunately, not as fast as @charliermarsh

I haven't forgotton about this PR but we first need to decide internally if we want to add more formatting lint rules and my priority for now is to fix...

Thank you @hoel-bagard for your patience and sorry that it took me so long. I started reviewing the rules but stopped after E125 because discovering all possible formatter incompatibilities took...

> I suspect that working directly on tokens would help with the performance issue. I used logical lines because that's what pycodestyle does, but I don't think that was a...