Micha Reiser

Results 745 comments of Micha Reiser
trafficstars

Is this a breaking change because we remove rules from a selector?

It might be fine, at least from our versioning policy. The change is reasonable to me but it might be worth documenting that all selects all not deprecated rules to...

I see this as a broader discussion around what commands rome offers and what differentiates them of each other. Adding a check argument to format raises the question how it...

``` const lorem = "foo"; if (lorem == "Foo") { // trigger the rule } ``` I doubt that a rule limited to this pattern will catch many bugs and...

It probably makes sense in all positions where a value is compared with a string.

> I agree the ignore lists should be additive, meaning the linter should ignore paths that match any pattern in both files.ignore and linter.ignore. What's your recommendation on the order...

Thank you so much @95th for this contribution. Looking all good. Can you rebase your changes to resolve the merge conflicts, and we're good to

A bit late, but there seems to be a github action https://github.com/marketplace/actions/rust-musl-builder-slim

I see multiple options to allow users to customize rome to their liking - Add an option to disable the extension if a project has no rome.json file - Add...

> I think the idea would be more to have different default configurations in different context, for instance to have recommended rules enabled by default in the CLI but disabled...