Vue-Socket.io icon indicating copy to clipboard operation
Vue-Socket.io copied to clipboard

Update to latest socket.io version

Open MariusVB opened this issue 4 years ago • 6 comments
trafficstars

Please update to the latest socket.io client, as backends start to implement it.

MariusVB avatar Dec 14 '20 10:12 MariusVB

Is this version update already tested?

Heiss avatar Feb 05 '21 13:02 Heiss

Any reason why this PR hasn't been accepted yet?

franjid avatar Feb 28 '21 19:02 franjid

From the following compatibility table

https://github.com/miguelgrinberg/python-socketio

Using a 2.x JS client limits which server versions are compatible. I regenerated a python virtual env (My back end service) and it pulled in the latest Socket.IO server, which does not work with the 2.x JS client. And thus, my vue application is dead in the water now :cry:

jeremy-prater avatar May 25 '21 03:05 jeremy-prater

Actually, looking at the change notes from 2.x to 3.x

https://socket.io/docs/v3/migrating-from-2-x-to-3-0/index.html

~We will need the ability to pass in some CORS options~

Disregard... You can already pass constructor options to the SocketIO constructor :+1: Should be good to merge

https://github.com/MetinSeylan/Vue-Socket.io/blob/master/src/index.js#L65

jeremy-prater avatar May 25 '21 04:05 jeremy-prater

Great, thanks! Let's merge it :)

MariusVB avatar May 25 '21 19:05 MariusVB

Similar PR in the same repo... https://github.com/MetinSeylan/Vue-Socket.io/pull/303

I'm not sure who has write access to merge.

jeremy-prater avatar May 27 '21 04:05 jeremy-prater