meteor-mocha icon indicating copy to clipboard operation
meteor-mocha copied to clipboard

Published 20 hours ago • verified publisher icon Meteor-Community-Packages

fix: Reload client side tests 2

Open jirkadev opened this issue 4 years ago • 3 comments

this PR fix the lint errors of this PR https://github.com/Meteor-Community-Packages/meteor-mocha/pull/106

After my use (8+ months) as a local package with this PR https://github.com/Meteor-Community-Packages/meteor-mocha/pull/106 I think it is good to merge as-is.

Client-side tests are reloaded correctly with this PR 95% time. Without this PR client-side tests are not reloaded at all. Rarely (5%) Chrome would crash when watching client tests, and mocha would need to be restarted.

jirkadev avatar Aug 18 '21 15:08 jirkadev

Hi @StorytellerCZ what do you think?

jirkadev avatar Aug 18 '21 15:08 jirkadev

@jirikrepl just some questions for testing it - do you run your tests in the browser or do you do headless testing with puppeteer or similar? Just want to focus on the modes you don't use.

Regarding 5% - what means "crash" ? Freezing? Or just doing nothing? Error messages?

jankapunkt avatar Aug 23 '21 07:08 jankapunkt

I am running client tests in headless mode with puppeteer. That 5% cases print some error about browser crash, but I am not sure. I would post it here when I see it again

jirkadev avatar Aug 25 '21 07:08 jirkadev