snaps icon indicating copy to clipboard operation
snaps copied to clipboard

Abstract system-level permissions

Open eriknson opened this issue 1 year ago • 5 comments

Some of our permissions might be too low-level for users to see during the installation phase.

Two things:

  • Potentially introduce another weight (5) to group these implicit permissions
  • Figure out where / how to show these in the UI (installation, settings, etc)
abstract-low-level-permissions

eriknson avatar Feb 29 '24 11:02 eriknson

Me and @FrederikBolding are thinking something along these lines: https://www.figma.com/file/Wlwk0cTx6PQkNhiX7vN13e/Snaps-Platform?type=design&node-id=1648%3A21759&mode=design&t=J5R8zcPzxjEqEYTf-1

eriknson avatar Mar 20 '24 16:03 eriknson

Basically, we abstract on the installation & update request if permission count > 3 we hide permissions with weight > 3

eriknson avatar Mar 20 '24 16:03 eriknson

No need to introduce another weight (5) for now. List of all permissions and their weights: https://www.notion.so/metamask-consensys/bac3299d2c5241c599d2e5e7986e72f7?v=ef742a61bd844435b7171bd2e90b447e

eriknson avatar Mar 20 '24 16:03 eriknson

Let's abstract permissions following these rules;

  • Installation: if permission count > 3 we hide permissions with weight > 3 (always show at least 3 permissions)
  • Update: Always show requested and revoked permissions and approved permissions < weight 3 and if no requested or revoked permissions, show at least 3 permissions either way
abstract-low-level-permissions

eriknson avatar Mar 28 '24 13:03 eriknson

“See all” doesn’t quite capture “we think this other stuff isn’t as dangerous”, imo.

danfinlay avatar Apr 24 '24 18:04 danfinlay

Given that we always have single permission displayed on Permission request screen, integration of abstraction will be skipped. We will revisit this part when Dynamic Permissions are integrated. At the moment, there are not enough permissions to apply and test the approach on the Permission request screen/flow.

david0xd avatar Jun 13 '24 10:06 david0xd